B-21170

Summary

Similar to an issue found in 21169's INT PR the new USPostRegionsCitiesID wasn't populating correctly in all scenarios. Often the DB contained all zeros (a.k.a. uuid.Nil). This should resolve that.

Verification Steps for the Author

These are to be checked by the author.

• Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
• Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

• Has the branch been pulled in and checked out?
• Have the BL acceptance criteria been met for this change?
• Was the CircleCI build successful?
• Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

• Instructions for starting storybook
• Instructions for starting the MilMove application
• Instructions for running tests

How to test

We have 6 forms to verify use the city finder and populate the USPostRegionsCitiesID.

1. Access the office app
2. Login as a prime simulator
3. Select any move
4. For each of the following check the network tab and DB to ensure a USPostRegionsCitiesID is being sent, stored, and returned:
5. Form 1 - Add a PPM shipment with secondary and tertiary addresses of both kinds
6. Form 2 - Modify that same PPM shipment being sure to change the addresses available to you
7. Form 1 (but for non-PPMs) - Create an HHG shipment with secondary and tertiary addresses of both kinds
8. Form 3 - Modify the pick up address of that HHG
9. Form 3 - With the same form, modify the destination address for that unapprove HHG
10. Form 4 - Identify an existing approved HHG, modify the destination address using the "Update Shipment Destination Address" form.
11. Optionally, access that same HHG as a TOO and approve the prime's request to change the address then verify the approved change displays correctly in the prime sim.
12. Form 5 - Identify an approved HHG that does not have an Origin SIT service item, add one.
13. Form 6 - Identify an approved HHG that does not have secondary or tertiary pickup or destination addresses (most e2e populate moves fit the bill). Update the shipment using "Update Shipment." You should be able to add secondary and tertiary pickup and destination addresses.

Frontend

• There are no aXe warnings for UI.
• This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
• There are no new console errors in the browser devtools.
• There are no new console errors in the test output.
• If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
• This change meets the standards for Section 508 compliance.

Backend

• Code follows the guidelines for Logging.
• The requirements listed in Querying the Database Safely have been satisfied.

Database

Any new migrations/schema changes:

• Follows our guidelines for Zero-Downtime Deploys.
• Have been communicated to #g-database.
• Secure migrations have been tested following the instructions in our docs.

Screenshots